Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precommit hooks for gitpod #5851

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

RayBB
Copy link
Collaborator

@RayBB RayBB commented Nov 10, 2021

Related to #5843

Precommit hooks will be setup automatically for gitpod environments.

This is ONLY to get precommit hooks setup. Autoformatting code on save will be a different PR.

Technical

  • pyenv install installs the version in .python-version as that's what's needed.
  • pip install pre-commit will install precommit to the local environment (since it doesn't run from inside docker).
  • pre-commit install actually installs the hooks.

Testing

You can test it out here: https://gitpod.io/#https://github.com/internetarchive/openlibrary/pull/5851

Screenshot

Stakeholders

@cclauss @cdrini

Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cclauss cclauss merged commit 8b934cf into internetarchive:master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants