Make "Return book" button go to loans page not editions page #5935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
added
the
Needs: Review
|
Solution LGTM, solves #2777 for @JeffKaplan. I originally implemented this to go to the editions page and feel OK about this change :) |
cdrini
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2777
feature
Technical
For redirecting after a book is returned, the route used is exactly the same as a different page that also redirects to loans. After returning a book, a function is called to update and remove the book from the loan list.
Testing
To test, return a book and ensure redirection to the original loans page. In addition, make sure the returned book is not on the list anymore (without having to refresh).
Screenshot
This feature does not directly touch UI, but we included a screenshot to display an empty loans page.
Stakeholders
N/A