Fix Subjects or Publishers with "/" in name causing problems #5940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
added
the
Needs: Review
|
@jimchamp mentions wishing we had a generalized solution for this, but for now, looks like it addresses the issue |
mekarpeles
removed
the
Needs: Review
cdrini
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #333
This is a review response to #5939
The discussion on #333 has got way out of hand and seems to have lost focus since the original report from 2016.
The original report deals with the subject search page for the specific query:
https://openlibrary.org/search/subjects?q=business+economics&mode=everything
The two problem examples from the original report are the URLs:
Which have the link texts:
The correct working destinations for these two are:
The ampersand does not appear to need encoding.
encoding the
/to%2F(which #5939 does) also 404s: https://openlibrary.org/subjects/business_&_economics_%2F_managementso isn't correct.
Parenthesis in subjects from the subject page also don't appear to have a 404 problem:
Searching for https://openlibrary.org/search/subjects?q=Children%3A+Young+Adult the first two examples are:
I can't find any subjects with the other characters
!./<>\\^|´™in that PR, but having some examples that demonstrate a problem would be helpful before making any more code changes.It looks like there are similar encoding problems in other parts of the code, which is why the discussion got over complicated.
I believe this fixes #333 , any other problems should be raised with clear examples showing a new issue.
Technical
Testing
Screenshot
Stakeholders