Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sticky menu on book pages #5947

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Fix sticky menu on book pages #5947

merged 1 commit into from
Dec 8, 2021

Conversation

jimchamp
Copy link
Collaborator

@jimchamp jimchamp commented Dec 8, 2021

Closes #5944

Fixes sticky menu on book pages.

Technical

Testing

Screenshot

sticky_screen_capture

Stakeholders

cdrini
cdrini approved these changes Dec 8, 2021
View reviewed changes
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, short, sweet, and to the point! Confirmed working on FF/Win10. Note it doesn't work on mobile, but that's another issue.

@cdrini cdrini merged commit 7aa2a49 into internetarchive:master Dec 8, 2021
@cdrini cdrini self-assigned this Dec 8, 2021
@jimchamp jimchamp deleted the 5944/bug/fix-sticky-menu branch January 27, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrini cdrini cdrini approved these changes

Assignees

@cdrini cdrini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sticky menu bar on Books page is no longer sticky
2 participants
@jimchamp @cdrini