Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacing civicrm call with elastic #6013

Merged
merged 6 commits into from
Dec 28, 2021
Merged

replacing civicrm call with elastic #6013

merged 6 commits into from
Dec 28, 2021

Conversation

mekarpeles
Copy link
Member

@mekarpeles mekarpeles commented Dec 25, 2021

Closes #5801

Replaces CiviCRM call w/ Archive.org ElasticSearch queries (less reliance on additional services)

Technical

NOTE:
On staging, notes seems to be broken (but is working in production)
https://staging.openlibrary.org/people/mekBot/books/notes?debug=true

Testing

http://ol-dev1.us.archive.org:1337/people/mekBot/books/sponsorships

Screenshot

When on sponsorships tab
ol-dev1 us archive org_1337_people_mekBot_books_sponsorships

When not on sponsorships tab
ol-dev1 us archive org_1337_people_mekBot_books_currently-reading

Stakeholders

@cdrini @jimchamp @bfalling

@mekarpeles mekarpeles added the Priority: 1 Do this week, receiving emails, time sensitive, . [managed] label Dec 25, 2021
@mekarpeles mekarpeles force-pushed the 5801/hotfix/es-civi branch 3 times, most recently from 1a8b0ca to 59d069f Compare December 26, 2021 03:56
Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be good after the review notes are implemented. Will attempt to put this on testing when the new commit has been pushed.

mekarpeles and others added 3 commits December 27, 2021 23:47
Co-authored-by: jimchamp <jameschamp@acm.org>
Co-authored-by: jimchamp <jameschamp@acm.org>
@mekarpeles
Copy link
Member Author

All feedback should be addressed and the feature can be tested on http://ol-dev1.us.archive.org:1337

Co-authored-by: jimchamp <jameschamp@acm.org>
@mekarpeles mekarpeles merged commit 36a4925 into master Dec 28, 2021
@mekarpeles mekarpeles deleted the 5801/hotfix/es-civi branch December 28, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 1 Do this week, receiving emails, time sensitive, . [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple OpenLibrary from Civi CRM
2 participants