-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replacing civicrm call with elastic #6013
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mekarpeles
added
the
Priority: 1
Do this week, receiving emails, time sensitive, . [managed]
label
Dec 25, 2021
mekarpeles
force-pushed
the
5801/hotfix/es-civi
branch
3 times, most recently
from
December 26, 2021 03:56
1a8b0ca
to
59d069f
Compare
mekarpeles
force-pushed
the
5801/hotfix/es-civi
branch
from
December 26, 2021 04:34
59d069f
to
2db9b94
Compare
jimchamp
reviewed
Dec 27, 2021
jimchamp
reviewed
Dec 27, 2021
jimchamp
reviewed
Dec 27, 2021
jimchamp
requested changes
Dec 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be good after the review notes are implemented. Will attempt to put this on testing when the new commit has been pushed.
Co-authored-by: jimchamp <jameschamp@acm.org>
Co-authored-by: jimchamp <jameschamp@acm.org>
All feedback should be addressed and the feature can be tested on http://ol-dev1.us.archive.org:1337 |
jimchamp
reviewed
Dec 28, 2021
Co-authored-by: jimchamp <jameschamp@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5801
Replaces CiviCRM call w/ Archive.org ElasticSearch queries (less reliance on additional services)
Technical
NOTE:
On staging, notes seems to be broken (but is working in production)
https://staging.openlibrary.org/people/mekBot/books/notes?debug=true
Testing
http://ol-dev1.us.archive.org:1337/people/mekBot/books/sponsorships
Screenshot
When on
sponsorships
tabWhen not on
sponsorships
tabStakeholders
@cdrini @jimchamp @bfalling