Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding trending view #6014

Merged
merged 3 commits into from
Feb 8, 2022
Merged

Adding trending view #6014

merged 3 commits into from
Feb 8, 2022
+130 −14

Conversation

mekarpeles
Copy link
Member

@mekarpeles mekarpeles commented Dec 26, 2021 •
edited
Loading

From 2022 Roadmap: build on https://openlibrary.org/stats/readinglog (prereq for following patrons #739 + #1964 #857 #3449)

Shows a ~realtime list of books being logged by patrons

Proposal

This should definitely be a homepage carousel, cached every 5 minutes!

Technical

  • On https://openlibrary.org/stats/readinglog we have trending all time & this month
  • Next up is adding a view for today, this week
  • And combining these all into a usable interface (rather than all squished on one page)
  • Before we show usernames, the privacy setting need to be tweaked to only include those with public reading logs mark as anonymous for now

Testing

Try it here: http://ol-dev1.us.archive.org:1337/trending

Screenshot

ol-dev1 us archive org_1337_trending

Stakeholders

@mekarpeles mekarpeles added this to the Next (proposed) milestone Dec 26, 2021
@MignonBelongie
Copy link

I still can't access the test link above. I get "ol-dev1.us.archive.org took too long to respond."

@mekarpeles mekarpeles mentioned this pull request Jan 4, 2022
Open
@mekarpeles mekarpeles assigned mekarpeles and unassigned cdrini Jan 24, 2022
@mekarpeles mekarpeles marked this pull request as ready for review January 28, 2022 05:33
@mekarpeles mekarpeles added the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Jan 28, 2022
@cdrini cdrini assigned jimchamp and unassigned mekarpeles Feb 2, 2022
jimchamp
jimchamp requested changes Feb 2, 2022
View reviewed changes
Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge after the suggestions/questions have been addressed.

@mekarpeles mekarpeles added the Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] label Feb 7, 2022
@mekarpeles mekarpeles self-assigned this Feb 7, 2022
@mekarpeles mekarpeles added the Priority: 1 Do this week, receiving emails, time sensitive, . [managed] label Feb 7, 2022
@mekarpeles mekarpeles removed the Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] label Feb 8, 2022
jimchamp
jimchamp approved these changes Feb 8, 2022
View reviewed changes
Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtrm! Works as expected when testing locally.

@jimchamp jimchamp merged commit a67cedf into master Feb 8, 2022
@jimchamp jimchamp removed their assignment Feb 24, 2022
This was referenced Feb 25, 2022
Closed
Merged
@cdrini cdrini deleted the trending branch March 24, 2022 15:50
@jimchamp jimchamp removed the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 2, 2024
This was referenced Dec 31, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrini cdrini cdrini left review comments

@jimchamp jimchamp jimchamp approved these changes

Assignees

@mekarpeles mekarpeles

Labels
Priority: 1 Do this week, receiving emails, time sensitive, . [managed]
Projects
None yet
Milestone
Sprint 2022-02
Development

Successfully merging this pull request may close these issues.
4 participants
@mekarpeles @MignonBelongie @cdrini @jimchamp