Disable ground-truth availability checks #6078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimchamp
added
the
On testing.openlibrary.org
|
I would like to get some baseline metrics for borrow failures before this gets merged. Converting to draft until we discuss the plan. |
mekarpeles
reviewed
Feb 3, 2022
mekarpeles
reviewed
Feb 9, 2022
|
Note: on http://ol-dev1.us.archive.org:1337/ (not testing -- I think there may have been a conflict w/ branches on testing) |
|
This successfully and appropriately hits the This successfully uses Another example here ~1.5s |
mekarpeles
added
the
Patch Deployed
jimchamp
removed
the
On testing.openlibrary.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables ground-truth availability calls for book page main borrow buttons. Adds additional profiling to LoanStatus.html.
Technical
Testing
Screenshot
Stakeholders
@mekarpeles