Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes ImportBot importing non-covers (For Amazon Imports) #6109

Conversation

b2pacific
Copy link
Contributor

@b2pacific b2pacific commented Feb 4, 2022

Closes #6089

hotfix

Technical

Currently added the file name of the placeholder image that we could find online, the filename might change in the future.

Testing

Screenshot

Stakeholders

@jimchamp @mekarpeles

@mekarpeles
Copy link
Member

This LGTM @jimchamp we may want to patch deploy and manually try adding on testing before merging

@tuminzee tuminzee changed the title Checking if the image file for the cover is 01RmK+J4pl which is a pla… Closes ImportBot importing non-covers (For Amazon Imports) Feb 4, 2022
@tuminzee
Copy link
Collaborator

tuminzee commented Feb 4, 2022

Hi @b2pacific I updated it with a more meaningful name.

Let's use self-documenting titles for issues and pull requests. When looking at a list like:
https://github.com/internetarchive/openlibrary/pulls

@mekarpeles
Copy link
Member

@cdrini + @jimchamp confirmed that the image key of the work coming through our API is:

[{'url': 'https://www.amazon.com/dp/0231206666/?tag=internetarchi-20', 'source_records': ['amazon:0231206666'], 'isbn_10': ['0231206666'], 'isbn_13': ['9780231206662'], 'price': '$90.00', 'price_amt': 9000, 'title': 'The Modern Presidency: Six Debates That Define the Institution', 'cover': 'https://m.media-amazon.com/images/I/01RmK+J4pJL._SL500_.gif', 'authors': [{'name': 'Genovese, Michael'}], 'publishers': ['Columbia University Press'], 'number_of_pages': 160, 'edition_num': None, 'publish_date': 'Sep 20, 2022', 'product_group': 'Book', 'physical_format': 'hardcover'}]

which matches 01RmK+J4pJL

We also confirmed with 9786057834683

Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks @b2pacific!

@jimchamp jimchamp merged commit 6610a1b into internetarchive:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportBot importing non-covers
4 participants