Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorting ia solr field #6125

Merged
merged 6 commits into from
Mar 17, 2022
Merged

Sorting ia solr field #6125

merged 6 commits into from
Mar 17, 2022

Conversation

mekarpeles
Copy link
Member

@mekarpeles mekarpeles commented Feb 8, 2022 •
edited
Loading

Closes #6068

Technical

Testing

Screenshot

Stakeholders

@mekarpeles mekarpeles force-pushed the 6068/hotfix/solr-sort-ia branch 9 times, most recently from d9b856c to f7dc06c Compare March 11, 2022 06:17
@mekarpeles mekarpeles marked this pull request as ready for review March 11, 2022 06:17
@mekarpeles mekarpeles force-pushed the 6068/hotfix/solr-sort-ia branch from f7dc06c to 79f2355 Compare March 11, 2022 06:27
@mekarpeles mekarpeles changed the title mvp for sorting ia solr field Sorting ia solr field Mar 11, 2022
@mekarpeles mekarpeles added the Priority: 1 Do this week, receiving emails, time sensitive, . [managed] label Mar 11, 2022
cdrini
cdrini requested changes Mar 12, 2022
View reviewed changes
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goog problem seems like a regression worth fixing

openlibrary/tests/solr/test_update_work.py Outdated Show resolved Hide resolved
openlibrary/solr/update_work.py Outdated Show resolved Hide resolved
openlibrary/solr/update_work.py Outdated Show resolved Hide resolved
openlibrary/solr/update_work.py Outdated Show resolved Hide resolved
@mekarpeles mekarpeles mentioned this pull request Mar 14, 2022
Closed
@mekarpeles mekarpeles added the Needs: Feedback A proposed feature or bug resolution needs community feedback prior to forging ahead. [managed] label Mar 14, 2022
@mekarpeles mekarpeles added this to the Active Sprint milestone Mar 14, 2022
@mekarpeles mekarpeles force-pushed the 6068/hotfix/solr-sort-ia branch from 681cfbd to 1c408d0 Compare March 17, 2022 19:37
@mekarpeles mekarpeles force-pushed the 6068/hotfix/solr-sort-ia branch from 1c408d0 to 6e69354 Compare March 17, 2022 19:42
cdrini
cdrini approved these changes Mar 17, 2022
View reviewed changes
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm; we tested: open book (hamlet), invalid ocaid (Not Under forty) work correctly; we'll know for certain during the next full reindex #5827 .

@cdrini cdrini merged commit 2a96fc6 into master Mar 17, 2022
@cdrini cdrini deleted the 6068/hotfix/solr-sort-ia branch March 17, 2022 19:45
@cdrini cdrini mentioned this pull request Mar 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrini cdrini cdrini approved these changes

Assignees

@cdrini cdrini

Labels
Needs: Feedback A proposed feature or bug resolution needs community feedback prior to forging ahead. [managed] Priority: 1 Do this week, receiving emails, time sensitive, . [managed]
Projects
None yet
Milestone
Sprint 2022-03
Development

Successfully merging this pull request may close these issues.

During Solr-reindex, sort ia fields by most likely readable
2 participants
@mekarpeles @cdrini