Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fulltext search to onboarding carousel #6148

Merged
merged 4 commits into from
Feb 16, 2022
Merged

Add fulltext search to onboarding carousel #6148

merged 4 commits into from
Feb 16, 2022

Conversation

MdSahil-oss
Copy link
Contributor

What issue does this PR close?
Closes #6123

What does this PR achieve? [feature|hotfix|fix|refactor]
Add new card of Fulltext searching in the Carousel.

For more Info checkout the issue #6123

Technical

Testing

Screenshot

Stakeholders

@MdSahil-oss
Copy link
Contributor Author

@tuminzee and @mekarpeles is it okay? or i need to improve it more

@tuminzee
Copy link
Collaborator

Hello @MdSahil-oss you failed one of the tests here.
for leads to merge your PR, you will first have to pass all the tests.
You can go in the details section and find out more about why the test failed.

I will assist you on how you can do it
go here

here you can see this error
image
Fix this one, add a commit. I am sure you will be able to solve it.
If you are stuck let me know :)

@mekarpeles mekarpeles self-assigned this Feb 15, 2022
@mekarpeles
Copy link
Member

lgtm, tested here http://ol-dev1.us.archive.org:1337/
nicely done!

@mekarpeles mekarpeles merged commit d01fd40 into internetarchive:master Feb 16, 2022
@cdrini cdrini changed the title Update carousel Add fulltext search to onboarding carousel Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Homepage Onboarding Card: Fulltext Search
4 participants