Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent new book page rendering errors #6151

Merged
merged 2 commits into from
Feb 16, 2022

Conversation

jimchamp
Copy link
Collaborator

Closes #6150

Removes unused variable book_description from the edition page template. Sometimes, AttributeErrors are thrown when this variable is set.

Technical

Testing

Screenshot

Stakeholders

@jimchamp jimchamp marked this pull request as draft February 15, 2022 17:30
@mekarpeles mekarpeles self-assigned this Feb 15, 2022
@mekarpeles mekarpeles marked this pull request as ready for review February 16, 2022 22:19
@mekarpeles
Copy link
Member

tested w/ @jimchamp. The problem is when a work has no editions, page (the work) should be used in place of the edition.

@mekarpeles mekarpeles merged commit 11bf926 into internetarchive:master Feb 16, 2022
@jimchamp jimchamp deleted the 6150/bug/remove-dead-code branch February 17, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when rendering work page
2 participants