Collection page list carousels now support works #6155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h returns a list of works
…tion, which returns a collections of works for a key
…them in the final_ids list
mekarpeles
force-pushed
the
b2pacific-6130/fix/listCarousel
branch
2 times, most recently
from
9331245 to
9a04346
Compare
+ adds caching Co-authored-by: Jim Champ <jameschamp@acm.org>
mekarpeles
force-pushed
the
b2pacific-6130/fix/listCarousel
branch
from
9a04346 to
68e2930
Compare
|
@jimchamp and I paired on this + tested & CR'd. merging when the pipeline completes |
|
Thank you @b2pacific! Great work getting us started with this one. Switching to the List Seeds API was the key! |
cdrini
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6130 #6149
This supplants @b2pacific #6149 -- his changes remain intact here.