Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shebang lines in scripts/oldump.py and scripts/sitemaps/sitemaps.py #6163

Merged
merged 5 commits into from
Feb 22, 2022

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Feb 19, 2022

Fixes #5402
Run oldump.py on Python 3.9, not Python 2 or Python 3.5.
#! /usr/bin/env python --> #! /usr/bin/env python3

The trouble was that we have two versions of Python 3 on ol-home0:

  • /usr/bin/python3 is v3.5.2
  • /home/openlibrary/.pyenv/shims/python3 is v3.9.4

root sees the second but when we su openlibrary in the cron job, we go back to seeing the first.

Proposed solution: In oldump.sh ensure that we are using pyenv's Python v3.9.

Technical

Testing

Screenshot

Stakeholders

@cclauss cclauss changed the title Fix shebang line of scripts/oldump.py Fix shebang lines in scripts/oldump.py and scripts/sitemaps/sitemaps.py Feb 21, 2022
Copy link
Member

@mekarpeles mekarpeles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ty

@mekarpeles mekarpeles merged commit 9505239 into internetarchive:master Feb 22, 2022
@mekarpeles mekarpeles self-assigned this Feb 22, 2022
@cclauss cclauss deleted the Fix-oldump-shebang branch February 22, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Dumps not auto-generating
2 participants