rm encrypted daisy, add previews #6192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mekarpeles
added
the
Priority: 1
|
Marking as P1 because we've received a few emails about this. Also, this should improve the experience pretty significantly across the site (because of previews on lists / reading logs, etc). This also fixes the case where we showed a preview button when one wasn't actually available because of restrictions (Bulk Availability API solved this with |
Closed
|
Incognito, another test case |
|
Is the most up-to-date version of this on ol-mek? I'm still seeing Daisy links in search results there:
Going to test locally to see if this is really an issue. |
jimchamp
added
the
On testing.openlibrary.org
|
Disregard all of that. I somehow ended up in production from ol-mek. |
jimchamp
approved these changes
Mar 1, 2022
jimchamp
removed
the
On testing.openlibrary.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5279
Closes #5768
Builds from #5279
Not In Librarybtn ifPreviewis availableTechnical
is_previewablefield to render preview buttonTesting
on http://ol-dev1.us.archive.org:1337/
Screenshot
Stakeholders