Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reading Log json export breaks if Author is str key, not dict #6199

Merged
merged 5 commits into from
Feb 28, 2022
Merged

Reading Log json export breaks if Author is str key, not dict #6199

merged 5 commits into from
Feb 28, 2022

Conversation

MdSahil-oss
Copy link
Contributor

Closes #6168

Technical

Testing

Screenshot

Stakeholders

@mekarpeles
Copy link
Member

mekarpeles commented Feb 28, 2022 •
edited
Loading

this lgtm, thank you! I'll run CI and add to testing and then merge

@mekarpeles mekarpeles self-assigned this Feb 28, 2022
@mekarpeles
Copy link
Member

fixed and tested, merging when ci passes

@mekarpeles
Copy link
Member

Here's evidence of it working
http://ol-dev1.us.archive.org:1337/people/mekBot/books/already-read.json?debug=true

@mekarpeles mekarpeles changed the title Update log json endpoint Reading Log json export breaks if Author is str key, not dict Feb 28, 2022
@mekarpeles mekarpeles merged commit bf640c5 into internetarchive:master Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mekarpeles mekarpeles

Labels
On ol-mek
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MdSahil-oss @mekarpeles