Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to page in Daisy template #6208

Merged

Conversation

jimchamp
Copy link
Collaborator

@jimchamp jimchamp commented Feb 28, 2022

Closes #6183

Removes reference to page in Daisy macro. The macro appears to only be called from LoanStatus.html with a properly constructed URL.

Technical

Testing

Screenshot

Stakeholders

@mekarpeles

@jimchamp jimchamp added the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Feb 28, 2022
@jimchamp jimchamp changed the title Remove reference to page Remove reference to page in Daisy template Feb 28, 2022
@jimchamp jimchamp marked this pull request as ready for review February 28, 2022 23:58
@mekarpeles mekarpeles merged commit 8490564 into internetarchive:master Mar 1, 2022
@jimchamp jimchamp deleted the 6183/bug/daisy-parameter-fix branch July 15, 2022 23:13
@jimchamp jimchamp removed the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants