Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EACCES errors with package*.json #6225

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented Mar 3, 2022

Closes #6224

Fix. Apparently:

All new files and directories are created with a UID and GID of 0, unless the optional --chown flag specifies a given username, groupname, or UID/GID combination to request specific ownership of the copied content.

https://docs.docker.com/engine/reference/builder/#copy

Why this never broke stuff before? No clue. Could be because we updated to node 16. Could be because of a docker update.

Technical

Testing

  • ✅ Test on gitpod
  • Didn't test on linux ; but fixing gitpod is already win :P

Screenshot

Stakeholders

Apparently:

> All new files and directories are created with a UID and GID of 0, unless the optional --chown flag specifies a given username, groupname, or UID/GID combination to request specific ownership of the copied content.

https://docs.docker.com/engine/reference/builder/#copy

Why this never broke stuff before? No clue. Could be because we updated to node 16. Could be because of a docker update.
@cdrini cdrini marked this pull request as draft March 3, 2022 00:33
@cdrini cdrini changed the title Try to fix EACCESS errors with package*.json Try to fix EACCES errors with package*.json Mar 3, 2022
@cdrini cdrini changed the title Try to fix EACCES errors with package*.json Fix EACCES errors with package*.json Mar 3, 2022
@cdrini cdrini marked this pull request as ready for review March 3, 2022 00:37
@cdrini
Copy link
Collaborator Author

cdrini commented Mar 3, 2022

Actually gitpod now errored with a different error :(

Error response from daemon: failed to create symlink: /workspace/.docker-root/volumes/openlibrary_ol-nodemodules/_data/.bin/acorn: symlink ../acorn/bin/acorn /workspace/.docker-root/volumes/openlibrary_ol-nodemodules/_data/.bin/acorn: file exists

@cdrini cdrini added the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Mar 3, 2022
@mekarpeles
Copy link
Member

thank you!!

@mekarpeles mekarpeles merged commit 7edf4a8 into internetarchive:master Mar 3, 2022
@cdrini cdrini deleted the fix/docker-build-perms branch March 9, 2022 00:27
@jimchamp jimchamp removed the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker build failing due to npm permissions
3 participants