Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collapsible work descriptions #6243

Conversation

jimchamp
Copy link
Collaborator

@jimchamp jimchamp commented Mar 4, 2022

Closes #6172

Makes book page work descriptions collapsible.

Technical

Testing

  1. Navigate to a book page that has a lengthy work description.
  2. Scroll to the work details component, found below the editions table.
  3. Ensure that the work description is truncated, and that a "Read more" link is present below the description.
  4. Click the "Read more" link. Ensure that the entire description is displayed, the "Read more" link is hidden, and a "Read less" link is present.
  5. Click the "Read less" link. Ensure that the description assumes its previous truncated form.

Screenshot

collapsible_work_desc

Stakeholders

@mekarpeles mekarpeles merged commit b59400e into internetarchive:master Mar 4, 2022
@mekarpeles
Copy link
Member

lgtm ty! mostly cosmetic changes

@jimchamp jimchamp deleted the 6172/feature/collapsible-work-desc branch July 15, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collapsible work descriptions
2 participants