phase 2 editions table perf #6247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code lgtm! A unit test involving This also restores OpenStax trusted book provider buttons on testing (not sure if there's an issue for this). TBP buttons present: No TBP buttons: |
mekarpeles
commented
Mar 4, 2022
jimchamp
reviewed
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses performance issues on books pages w/ lots of editions + ebooks
Technical
By default, fetch up to 10 ebooks.
Otherwise, fetch 3 featured editions with covers (if possible)
Testing
Test https://testing.openlibrary.org/works/OL66554W/Pride_and_Prejudice
Stakeholders
@cdrini @jimchamp @seabelis @mheiman