Add bulk reading log query #6262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mekarpeles
reviewed
Mar 8, 2022
jimchamp
force-pushed
the
bulk-reading-log
branch
from
8347e9d to
9769875
Compare
|
One possible improvement I might have made is having the But I don't think this is a blocking change; I just imagine we'll probably DRY and be doing this sort of thing in other places / templates in the future But I think we can handle that when we get there :) this is a great step forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetches all reading log entries at once on search results pages if the patron is logged in.
Technical
Testing
Screenshot
Stakeholders