Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add book identifiers above the fold for librarians #6276

Conversation

jimchamp
Copy link
Collaborator

@jimchamp jimchamp commented Mar 10, 2022

In order to aid librarians, the following changes have been made:

  • Important identifiers are now available above the fold (for usergroup librarians).

Technical

Testing

Screenshot

Screenshot from 2022-03-10 15-31-06

sticky_title

Stakeholders

@jimchamp jimchamp requested a review from mekarpeles March 10, 2022 20:39
@mekarpeles mekarpeles self-assigned this Mar 14, 2022
@mekarpeles mekarpeles added the Priority: 2 Important, as time permits. [managed] label Mar 14, 2022
@jimchamp jimchamp force-pushed the librarians-book-page branch from 49ec075 to d26badd Compare March 17, 2022 18:05
@jimchamp jimchamp changed the title Book page improvements for librarians Add book identifiers above the fold for librarians Mar 17, 2022
@jimchamp jimchamp marked this pull request as draft March 17, 2022 20:30
@jimchamp jimchamp force-pushed the librarians-book-page branch from d26badd to 0282973 Compare March 17, 2022 22:20
@jimchamp jimchamp marked this pull request as ready for review March 17, 2022 22:36
@jimchamp
Copy link
Collaborator Author

Added omniline changes and removed sticky title.

Desktop view:
Screenshot from 2022-03-17 18-19-27

Mobile view:
Screenshot from 2022-03-17 18-19-12

@jimchamp jimchamp force-pushed the librarians-book-page branch from 5987e40 to ca97660 Compare March 17, 2022 23:05
@mekarpeles
Copy link
Member

lgtm ty!

@mekarpeles mekarpeles merged commit 8b16d60 into internetarchive:books-page-integration Mar 18, 2022
@jimchamp jimchamp mentioned this pull request Mar 21, 2022
@jimchamp jimchamp deleted the librarians-book-page branch July 15, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 2 Important, as time permits. [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants