Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement books page feedback #6313

Merged

Conversation

jimchamp
Copy link
Collaborator

This PR attempts to resolve any feedback given for the recent books page PRs. The following changes have been made:

  • Prompt to see all editions moved above editions table
  • Horizontal rule above editions table has been removed
  • Singular case handled correctly when one featured edition is displayed in the table
  • Removed OLID from omnibar
  • Add border around table

Technical

Testing

Screenshot

Stakeholders

- Nest table within `.tab-section`
-  Remove horizontal rule above table
- Move "View all editions" prompt above table
- Use proper singular form in editions count message
@mekarpeles mekarpeles changed the title Impliement books page feedback Implement books page feedback Mar 21, 2022
@mekarpeles mekarpeles self-assigned this Mar 21, 2022
@mekarpeles mekarpeles added the Priority: 1 Do this week, receiving emails, time sensitive, . [managed] label Mar 21, 2022
@mekarpeles
Copy link
Member

lgtm

@mekarpeles mekarpeles merged commit c4126aa into internetarchive:books-page-integration Mar 21, 2022
@jimchamp jimchamp mentioned this pull request Mar 21, 2022
@jimchamp jimchamp deleted the book-page-review branch July 15, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 1 Do this week, receiving emails, time sensitive, . [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants