Add subject clamping conditionally #6325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimchamp
added
State: Blocked
mekarpeles
added
the
State: Blocked
|
RSLGTM (design is a step up) |
mekarpeles
added
the
Priority: 1
jimchamp
force-pushed
the
expandable-subjects
branch
from
b400bc5 to
9c8856c
Compare
jimchamp
removed
the
State: Blocked
jimchamp
commented
Mar 28, 2022
|
lgtm ty! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes clamper symbols from "+" and "-" to a small right-pointing triangle and a small down-pointing arrow, respectively.
Only adds clamp symbol and click listener if the content is able to be clamped.
Blocked until #6323 is merged. Alternatively, this can be merged into the
books-page-integrationbranch.Technical
Testing
Screenshot
Stakeholders