Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect selected element in navbar on fast scroll #6327

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

jimchamp
Copy link
Collaborator

Corrects issue where position-aware navbar is not updating properly when the page is quickly scrolled.

Technical

Testing

Screenshot

superb_scrolling

Stakeholders

@jimchamp jimchamp changed the title Fix navbar selected element on fast scroll Fix incorrect selected element in navbar on fast scroll Mar 24, 2022
@mekarpeles mekarpeles assigned mekarpeles and unassigned cdrini Apr 4, 2022
@mekarpeles mekarpeles added the Priority: 2 Important, as time permits. [managed] label Apr 4, 2022
@mekarpeles mekarpeles added the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 15, 2022
@mekarpeles mekarpeles merged commit e4e4e7e into internetarchive:master Apr 20, 2022
@jimchamp jimchamp removed the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label May 16, 2022
@jimchamp jimchamp deleted the bug/navbar-scrolling branch July 15, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 2 Important, as time permits. [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants