Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show publish places in book details #6334

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

jimchamp
Copy link
Collaborator

@jimchamp jimchamp commented Mar 28, 2022

Adds publisher locations to the book details component. These were previously displayed in the omniline. This information may be better placed in the new onmiline, but spacing issues in that component should be resolved first.

Removes publisher_line.html template, which should have been removed in #6323.

Technical

Testing

Screenshot

Screenshot from 2022-03-28 12-49-16

Stakeholders

@mekarpeles
Copy link
Member

+1 on the idea, no preference at this stage on the design

@mekarpeles mekarpeles self-assigned this Mar 28, 2022
@mekarpeles mekarpeles added the Priority: 2 Important, as time permits. [managed] label Mar 28, 2022
@mekarpeles mekarpeles merged commit e823c21 into internetarchive:master Mar 29, 2022
@jimchamp jimchamp deleted the show-publish-places branch July 15, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 2 Important, as time permits. [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants