Show multiple of each type of ISBN in omniline #6355
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6360
The previous means of getting ISBNs for the books page omniline only gets the first ISBN 10 and ISBN 13 if multiples exist for either. This PR ensures that all ISBNs are displayed in the omniline.
Technical
The new code is modeled after the
display_identifiers
function, which is used to display IDs in the book details section of the page. I'm assuming that theopenlib-
checks are not needed for ISBNs, and did not include them. Please correct me if I'm wrong.openlibrary/openlibrary/templates/type/edition/view.html
Lines 141 to 159 in a112a9e
Testing
Screenshot
Stakeholders