Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SpyPrint with capsys fixure #6381

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

jimman2003
Copy link
Contributor

refactor

Technical

This uses a pytest fixture capsys

Testing

These test should output the same results as the previous version

Screenshot

Stakeholders

@cdrini

@cdrini cdrini self-assigned this Apr 5, 2022
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Tests pass :) Made some small changes to formatting to make the comparison a little more compact.

@cdrini cdrini merged commit 2d99f0d into internetarchive:master Apr 5, 2022
@jimman2003 jimman2003 deleted the data_stdout_capture branch April 5, 2022 16:50
cclauss pushed a commit that referenced this pull request Apr 17, 2022
* Replace SpyPrint with capsys fixure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants