Remove read_serp.py,unused #6386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jimman2003 I'm not sure exactly what this script did / does, but I think it's safe to use. It looks like it was an early manual file based(?) method of importing from Amazon. Ok to merge from me. 👍🏽 |
|
Well read_serp is broken due to a stray continue, so I believe we should remove it anyways |
|
@jimman2003 oops, I meant to write "safe to remove", not sure how or why I typoed 'use' instead, sorry for being confusing. We agree that it should be removed :) |
cdrini
reviewed
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
Part of old book importing code?
Technical
No refs found though a grepping of the root directory
Testing
Amazon imports happen naturally
Screenshot
Stakeholders
@hornc