Fix Accesibility issues on the Login page concerning a button not getting focus #6403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbouris
changed the title
dbouris
changed the title
jimchamp
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6399
Accessibility
This pull request achieves fixing accessibility issues firstly in the Login page and other pages too. We noticed that the accessibility issue stated in #6399 applies to more pages and not only the Login page. So we removed the outline attribute from the common.less file to fix the issue in all the pages.
Technical
Removed the
from the common.less file.
Testing
Start from the top of the Login Page and using the tab button, while scrolling down, the login button does not get focus as it is supposed to. This applies to other pages to, such as the edit profile page.
Screenshot
Stakeholders
@mekarpeles
@cdrini
Attribution Disclaimer: By proposing this pull request, I affirm to have made a best-effort and exercised my discretion to make sure relevant sections of this code which substantially leverage code suggestions, code generation, or code snippets from sources (e.g. Stack Overflow, GitHub) have been annotated with basic attribution so reviewers & contributors may have confidence and access to the correct context to evaluate and use this code.