Fix "Previews available in:" sometimes displayed without any preview languages #6408 #6410
Conversation
Made the caption "Previews available in:" appear only when they are available preview languages.
for more information, see https://pre-commit.ci
| Previews available in: | ||
| $for e in previews: | ||
| $if len(e.languages)!=0: | ||
| Previews available in: |
There was a problem hiding this comment.
Question, will this result in the words "Previews available in" being displayed multiple times in the page?
There was a problem hiding this comment.
I see! We have a second for loop and are using breaks, that can work!
There was a problem hiding this comment.
By default, any non-zero number will be a True value, so can use len(e.languages) as an a equivalent to len(e.languages)!=0.
Another option is... on line L269 we can turn this into a list comprehension where we do something like...
$if previews and any([len(e.languages) for e in previews)]:
<p class="preview-languages">
Previews available in:
$for e in previews:
$if e.languages[0].name not in seen:
$ seen.add(e.languages[0].name)
<a href="$work.key?edition=$(e.ocaid)">$e.languages[0].name</a>
</p>
This way we don't render <p class="preview-languages"> if its not going to be used
There was a problem hiding this comment.
Thank you! Do you want me to change it in the way that you suggested?
There was a problem hiding this comment.
I implemented the changes
jimchamp
added
the
On testing.openlibrary.org
There was a problem hiding this comment.
Lgtm, and seems to be working on testing:
https://testing.openlibrary.org/works/OL4472450W/Shad?edition=ia%3Ashad0000corr
Compare to production:
https://openlibrary.org/works/OL4472450W/Shad?edition=ia%3Ashad0000corr
jimchamp
removed
the
On testing.openlibrary.org
Made the caption "Previews available in:" appear only when they are available preview languages.
Closes #6408
Screenshot
Stakeholders
@jimchamp