Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XSS in author name rendering #6413

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Fix XSS in author name rendering #6413

merged 1 commit into from
Apr 11, 2022

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented Apr 11, 2022 •
edited
Loading

Also properly i18n the list here

Closes #6406

Technical

Testing

Screenshot

image

Stakeholders

@jimchamp @tfmorris

@cdrini
Fix XSS in author name rendering
1eb9035 
Also properly i18n the list here
@cdrini cdrini added Priority: 0 Fix now: Issue prevents users from using the site or active data corruption. [managed] Patch Deployed This PR has been deployed to production independently, outside of the regular deploy cycle. labels Apr 11, 2022
jimchamp
jimchamp approved these changes Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jimchamp jimchamp merged commit 6e3d80d into internetarchive:master Apr 11, 2022
@cdrini cdrini deleted the 6406/fix-author-name-xss branch April 11, 2022 23:02
@cdrini cdrini mentioned this pull request Apr 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimchamp jimchamp jimchamp approved these changes

Assignees

@jimchamp jimchamp

Labels
Patch Deployed This PR has been deployed to production independently, outside of the regular deploy cycle. Priority: 0 Fix now: Issue prevents users from using the site or active data corruption. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-ASCII character rendering broken on author page
2 participants
@cdrini @jimchamp