Fix the 'When no star ratings on book, UI looks weird #6411' bug #6418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vassilis-Boubis
changed the title
Vassilis-Boubis
force-pushed
the
vassilis
branch
from
41a6135 to
d5334c2
Compare
mekarpeles
added
the
On testing.openlibrary.org
jimchamp
requested changes
Apr 13, 2022
| @@ -12,6 +12,7 @@ | |||
| $if (stats_decimal >= 0.5) and (stats_decimal < 1): | |||
| $:('<span class="readers-stats__star--half">★</span>') | |||
| <span itemprop="ratingValue">$avg</span> | |||
| <h4>·</h4> | |||
There was a problem hiding this comment.
Suggested change
| <h4>·</h4> | |
| <span>·</span> |
Let's change this to a span, and update the CSS accordingly. You can assign the span a unique class if it is helpful.
There was a problem hiding this comment.
Okey, I will fix it rigth now
Vassilis-Boubis
force-pushed
the
vassilis
branch
from
68f008c to
7f219aa
Compare
for more information, see https://pre-commit.ci
jimchamp
reviewed
Apr 13, 2022
jimchamp
removed
the
On testing.openlibrary.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6411
Technical
Testing
Screenshot
Stakeholders