Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add account deactivation link to user settings #6420

Merged
merged 2 commits into from
May 2, 2022

Conversation

mekarpeles
Copy link
Member

See https://testing.openlibrary.org/account updates account options, shows "account deactivation" as a setting

Stakeholders

@JeffKaplan @seabelis @cdrini

@mekarpeles
Copy link
Member Author

Let's please not merge this until after #6427

Some of the changes in this file will no longer be necessary (e.g. since Loans will appear on the account sidebar, it won't need to be listed under settings)

@mekarpeles mekarpeles added the State: Blocked Work has stopped, waiting for something (Info, Dependent fix, etc. See comments). [managed] label Apr 15, 2022
@mekarpeles mekarpeles removed the State: Blocked Work has stopped, waiting for something (Info, Dependent fix, etc. See comments). [managed] label Apr 22, 2022
@cdrini cdrini changed the title Update account.html Add account deactivation link to user settings Apr 25, 2022
@cdrini cdrini added the Priority: 1 Do this week, receiving emails, time sensitive, . [managed] label Apr 25, 2022
@mekarpeles mekarpeles merged commit cf6021b into master May 2, 2022
@mekarpeles mekarpeles deleted the improve-account-settings branch May 2, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 1 Do this week, receiving emails, time sensitive, . [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants