Don't show read more link when not needed #6428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tangym27, this looks like a great direction to me, stellar job on this PR and thank you for including the screencast! |
|
Tests are failing on coverage (which is OK) we just need to change the coverage % here: You can see the test coverage errors here to determine how much we should increase the limits by: |
mekarpeles
added
the
On testing.openlibrary.org
mekarpeles
added
the
Priority: 1
tangym27
force-pushed
the
read-more-link
branch
from
62c4865 to
fb55cde
Compare
cdrini
reviewed
Apr 20, 2022
Co-authored-by: Drini Cami <cdrini@gmail.com>
cdrini
approved these changes
Apr 20, 2022
cdrini
changed the title
jimchamp
removed
the
On testing.openlibrary.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6401
Technical
SearchBar.js58is based off of the height of.restricted-height(made a comment in the code itself)Testing
(Locally): http://localhost:8080/works/OL13101191W/Alice%27s_Adventures_in_Wonderland
Screenshot
With resizing in action (sorry for low quality):
Stakeholders
@jimchamp