Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRY Book Byline rendering + make it more i18n-able #6474

Merged
merged 4 commits into from
Apr 26, 2022
Merged

DRY Book Byline rendering + make it more i18n-able #6474

merged 4 commits into from
Apr 26, 2022

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented Apr 22, 2022 •
edited
Loading

Prep refactor of some code for editions in solr.

Technical

  • Uses babel to commify lists instead of manual ', '.join combining. This i18n better
  • Delete an old template, but there are load of other places we do this type of thing

Testing

Screenshot

  • Edit pages now also link to authors

Stakeholders

@cdrini cdrini added the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 22, 2022
@cdrini cdrini force-pushed the refactor/BookByline branch from f1e351a to cd69506 Compare April 22, 2022 23:03
@cdrini cdrini force-pushed the refactor/BookByline branch from cd69506 to 88431e6 Compare April 22, 2022 23:08
@cdrini cdrini added the Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed] label Apr 22, 2022
@cdrini cdrini assigned jimchamp and mekarpeles and unassigned mekarpeles Apr 25, 2022
@cdrini cdrini added the Priority: 1 Do this week, receiving emails, time sensitive, . [managed] label Apr 25, 2022
jimchamp
jimchamp approved these changes Apr 26, 2022
View reviewed changes
Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jimchamp jimchamp merged commit ca38d6a into internetarchive:master Apr 26, 2022
@cdrini cdrini deleted the refactor/BookByline branch April 26, 2022 09:08
@jimchamp jimchamp removed the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimchamp jimchamp jimchamp approved these changes

Assignees

@jimchamp jimchamp

Labels
Priority: 1 Do this week, receiving emails, time sensitive, . [managed] Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdrini @jimchamp @mekarpeles