-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix overlapping of profile icon and hamburger icon in mobile view #6477
Fix overlapping of profile icon and hamburger icon in mobile view #6477
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @constantinazouni ! I've placed this on testing.openlibrary.org to try it out 👍 Noticing the behaviour looks a little off when the button is clicked:
We'll want to make this css .header-bar .hamburger-component details[open] .hamburger__icon
apply to the summary
element instead of just the icon.
And we can probably also delete some of the old css around position: absolute
on the .account__icon
.
Otherwise it's working well!
I improved the behavior of the button when it is clicked. I couldn't really remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm! Thanks, @constantinazouni !
IIRC the position: absolute
was added to make the icon overlap the hamburger icon; we can probably remove it and make it behave more like a "normal" element, maybe a display: flex
with some padding between them, as opposed to having the padding of the hamburger icon "consume" the other icon. Not a blocker though, just always nice to delete code :)
Closes #5985
Technical
We added come CSS.
Screenshot
Stakeholders
@cdrini