Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overlapping of profile icon and hamburger icon in mobile view #6477

Merged
merged 7 commits into from
Apr 27, 2022

Conversation

constantinazouni
Copy link
Contributor

Closes #5985

Technical

We added come CSS.

Screenshot

image

Stakeholders

@cdrini

@cdrini cdrini self-assigned this Apr 25, 2022
@cdrini cdrini added the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 26, 2022
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @constantinazouni ! I've placed this on testing.openlibrary.org to try it out 👍 Noticing the behaviour looks a little off when the button is clicked:
image

We'll want to make this css .header-bar .hamburger-component details[open] .hamburger__icon apply to the summary element instead of just the icon.

And we can probably also delete some of the old css around position: absolute on the .account__icon.

Otherwise it's working well!

@cdrini cdrini added the Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] label Apr 26, 2022
@constantinazouni
Copy link
Contributor Author

I improved the behavior of the button when it is clicked. I couldn't really remove the position: absolute because it affected the position of the account icon. Let me know if you want further changes.

@cdrini cdrini removed the Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] label Apr 27, 2022
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm! Thanks, @constantinazouni !

IIRC the position: absolute was added to make the icon overlap the hamburger icon; we can probably remove it and make it behave more like a "normal" element, maybe a display: flex with some padding between them, as opposed to having the padding of the hamburger icon "consume" the other icon. Not a blocker though, just always nice to delete code :)

@cdrini cdrini merged commit 611bee0 into internetarchive:master Apr 27, 2022
@jimchamp jimchamp removed the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlapping of profile icon and hamburger icon in mobile view
4 participants