Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent dupes from affiliate-server queue #6501

Merged
merged 1 commit into from
May 2, 2022
Merged

prevent dupes from affiliate-server queue #6501

merged 1 commit into from
May 2, 2022

Conversation

mekarpeles
Copy link
Member

Related to #5474

fixes dupes from recache memoize entering queue

Technical

Testing

Screenshot

Stakeholders

@cdrini cdrini added the Patch Deployed This PR has been deployed to production independently, outside of the regular deploy cycle. label Apr 29, 2022
@mekarpeles
Copy link
Member Author

  1. when using /isbn/{isbn} we try to fetch book from OL or hit vendor sources just-in-time
  2. when we hit vendor sources, we check cache. If cache returns None, we update the cache.
    1. this may result in the ISBN getting submitted twice? especially w/ the 3x retry code
  3. we updated the affiliate-service to only add ISBN to queue if ISBN not already on queue.
    1. this seems to have a drastic change to its processing efficiency

@mekarpeles mekarpeles assigned cdrini and unassigned cclauss May 2, 2022
@mekarpeles mekarpeles added the Priority: 2 Important, as time permits. [managed] label May 2, 2022
cdrini
cdrini approved these changes May 2, 2022
View reviewed changes
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm; we confirmed this works on ol-home

@cdrini cdrini merged commit 238bdfe into master May 2, 2022
@cdrini cdrini deleted the hotfix/affiliate-server branch May 2, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrini cdrini cdrini approved these changes

Assignees

@cdrini cdrini

Labels
Patch Deployed This PR has been deployed to production independently, outside of the regular deploy cycle. Priority: 2 Important, as time permits. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mekarpeles @cdrini @cclauss