Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n language names wherever they appear #6502

Merged
merged 5 commits into from
May 9, 2022

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented Apr 28, 2022

Closes #6246

Technical

  • Also DRY'd up a few util functions

Testing

Add ?lang=fr and see everything change!

Screenshot

image
image
image
image
image
image
image
image
image

Stakeholders

@tfmorris @bicolino34 @dcapillae

@cdrini cdrini changed the title Make autocomplete use i18n'd language names i18n language names wherever they appear Apr 29, 2022
@cdrini cdrini marked this pull request as ready for review April 29, 2022 17:51
@cdrini cdrini added the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 29, 2022
@mekarpeles mekarpeles self-assigned this May 2, 2022
@mekarpeles mekarpeles added the Priority: 1 Do this week, receiving emails, time sensitive, . [managed] label May 2, 2022
@bicolino34
Copy link
Collaborator

This also closes #865

@mekarpeles mekarpeles merged commit 6cb5b83 into internetarchive:master May 9, 2022
@jimchamp jimchamp removed the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 1 Do this week, receiving emails, time sensitive, . [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Original names for languages
4 participants