Anonymize patron data #6503
Merged
Anonymize patron data #6503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds "Anonymize Account" button to `/admin/people` view - Adds CommonExtras update and delete by username functions - Adds anonymize function to Account, which updates OL tables in test mode
- Remove patron from all usergroups - Reset preferences to default - Clear patron's User data - Set type to `/type/delete`
|
Keeping this in draft, as it doesn't yet address some things:
|
|
Add dialog or something to confirm action. Also, maybe change the location of the button to avoid misclicks. |
- Move anonymization button to admin history table - Add confimation dialog for anonymization
|
Running into issues anonymizing keys, which is how we planned on anonymizing lists and edit history. If it turns out that changes keys is not possible, maybe it would be best to change ownership of lists and history to a dummy account the represents anonymized patrons? Either way, suggest adding this functionality in a PR to be opened in the near future. |
jimchamp
commented
May 27, 2022
Comment on lines
227
to
233
| <script> | ||
| function confirmAnonymize(event) { | ||
| if(!confirm('Really anonymize this patron? This will delete the patron\'s profile page and booknotes, and anonymize the patron\'s reading log, reviews, and star ratings.')) { | ||
| event.preventDefault() | ||
| } | ||
| } | ||
| </script> |
There was a problem hiding this comment.
If we're happy with the confirmation dialog approach, I can move this inline JS to a .js file.
mekarpeles
added
the
Priority: 1
- Adds "Dry run" checkbox next to anonymize button - When "Dry run" is checked, changes to the account are not persisted - Adds patron's display name to confirmation dialog
- Preferences now updated correctly - Patrons redirected to deleted profile page when viewing anonymized reading log page
|
Today's changes:
|
jimchamp
added
the
On testing.openlibrary.org
mekarpeles
reviewed
Jun 8, 2022
| <form method="POST" id="anonymize-form" action="?debug=true"> | ||
| <input type="checkbox" id="dry-run-checkbox" name="dry_run"> | ||
| <label for="dry-run-checkbox">Dry Run</label> | ||
| <button type="submit" name="action" value="anonymize_account" style="float: right;" class="account-anonymization-button" data-display-name="$person.username">$_("Anonymize Account")</button> |
jimchamp
removed
the
On testing.openlibrary.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4875, #6455, #5014
Creates the means for an admin to anonymize a patron's account. This PR can be moved from draft when the following tasks are complete:
/admin/peopleviewtestflag for anonymize function (no updates/deletions are committed whiletestis true)Technical
The
/admin/people/view.htmltemplate was producing invalid HTML. The initial commit of this PR solely addresses those issues.Important Note: If the anonymization process throws an error before it completes we can re-run, but some operations may not be possible during the re-run. This may result in some lingering records.
Testing
Screenshot
New button in
/admin/people.Flash message that is displayed on success
Stakeholders
@mekarpeles