Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Wikipedia Cite book format #6516

Merged
merged 5 commits into from
Jun 17, 2022
Merged

Conversation

hornc
Copy link
Collaborator

@hornc hornc commented May 5, 2022

Closes #

  • Matches order of Cite book template (completes the move from the original Citation template)
  • Strips whitespace from LCCNs (whitespace breaks the loc link)
  • Correctly adds ISSNs, if present
  • Correctly adds first_publish_date if different from date

Technical

Testing

Screenshot

Before:
image
After:
image

Stakeholders

@hornc
Copy link
Collaborator Author

hornc commented May 5, 2022

Ideas for further improvements (in a subsequent PR or issue):

  • Use last{n}= first{n}= in place of author{n} if the author field contains no commas and can be assumed to be in 'natural name' order. Might need to check eastern_order to get this right in all cases.
  • Use ISO 639 language code for language: (if available)
  • ol-access=free to be set if there is a free access, non-registered version available
  • Hyphenate ISBNs for display (e.g. using something like https://github.com/hornc/isbn_hyphenate ) (Out of scope?)

@mekarpeles mekarpeles marked this pull request as draft May 9, 2022 20:04
@hornc hornc changed the title WIP: Update Wikipedia Cite book format Update Wikipedia Cite book format Jun 9, 2022
@hornc hornc marked this pull request as ready for review June 9, 2022 02:52
@mekarpeles mekarpeles self-assigned this Jun 13, 2022
@mekarpeles mekarpeles added the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Jun 16, 2022
@mekarpeles mekarpeles merged commit d4bb231 into internetarchive:master Jun 17, 2022
@hornc hornc deleted the wikicite branch August 19, 2022 05:40
@jimchamp jimchamp removed the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants