Removes link around book page publish location #6529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mekarpeles
added
the
On testing.openlibrary.org
|
@mekarpeles It seems that it makes published in field just a plain text without hyperlink link to anywhere |
|
We made a decision to remove the links for now for published in (which previously linked to a subject, which was confusing) |
jimchamp
removed
the
On testing.openlibrary.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6518
This removes the link around the book page publish location because it was bringing patrons to a subject results page often with no results (and the experience wasn't very intuitive)
Technical
Testing
Once on testing.openlibrary.org, go to a books page and look at the "published in" section an ensure the item gets rendered as text and not a link
Screenshot
Stakeholders