Update wmd vendor to fix XSS #6543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
added
On testing.openlibrary.org
|
P0 so it goes out in the next deploy. |
|
Auto-merging; small change with low consequences (if there's an error, it'll just prevent the preview from rendering entirely, which also fixes the XSS :P ). Confirmed working correctly on FF. Not can't patch deploy JS changes easily, so deployed a temporary patch instead. |
jimchamp
removed
the
On testing.openlibrary.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6533 . Closes #6544 . Makes the wmd preview have a strict includelist of html attributes. NOTE! This will still allow all attrs to be added / saved, but just ignored when rendering the preview.
See internetarchive/wmd@f07d5e4 for actual diff.
Technical
Testing
I <img src="http" onerror="alert('hi')">this bookin work description field: https://testing.openlibrary.org/books/OL12017920M/Hello..._Hello/edit ; no xss!Screenshot
Stakeholders