Make Country of Birth only show modern-day countries and countries at author birthdate in reading stats #6550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
changed the title
for more information, see https://pre-commit.ci
cdrini
added
the
On testing.openlibrary.org
jimchamp
removed
the
On testing.openlibrary.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQUASH ME
Previously, the "Country of Birth" section of reading log stats would show historical countries that had no real relation to the author (eg it might show "Ancient Greece" for someone born in modern day Greece). Change it so that it now only counts modern day countries (which are probably more recognizable to most folks) as well as the historical country that existed at the time of the author's birth (technically more correct).
Technical
Testing
Compare the reading stats for "Country of Birth" on staging vs testing.
Screenshot
Here's how mine changed:
Stakeholders
@bicolino34