Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing deploy git cmds #6562

Merged
merged 1 commit into from
May 23, 2022
Merged

fixing deploy git cmds #6562

merged 1 commit into from
May 23, 2022

Conversation

mekarpeles
Copy link
Member

trivial fixes to unbreak our deploys (since git now requires sudo in the deployment context)

@mekarpeles mekarpeles added Affects: Admin/Maintenance Issues relating to support scripts, bots, cron jobs and admin web pages. [managed] Affects: Configuration Related to the configuration of the dev/staging/prod environments, CI, docker, etc. [managed] Affects: Server Issues with the server (olweb) or its plugins. [managed] Patch Deployed This PR has been deployed to production independently, outside of the regular deploy cycle. labels May 18, 2022
cclauss
cclauss approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@mekarpeles mekarpeles added the Priority: 1 Do this week, receiving emails, time sensitive, . [managed] label May 23, 2022
cdrini
cdrini approved these changes May 23, 2022
View reviewed changes
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! We ran this during deploy and it worked. The new git update prevents you from running git status (or any git cmd) if you're not the owner of the repo :/

@cdrini cdrini merged commit b11287d into master May 23, 2022
@cdrini cdrini deleted the fix-deploy branch May 23, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrini cdrini cdrini approved these changes

@cclauss cclauss cclauss approved these changes

Assignees

@cdrini cdrini

Labels
Affects: Admin/Maintenance Issues relating to support scripts, bots, cron jobs and admin web pages. [managed] Affects: Configuration Related to the configuration of the dev/staging/prod environments, CI, docker, etc. [managed] Affects: Server Issues with the server (olweb) or its plugins. [managed] Patch Deployed This PR has been deployed to production independently, outside of the regular deploy cycle. Priority: 1 Do this week, receiving emails, time sensitive, . [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mekarpeles @cclauss @cdrini