Create a Trending Books Carousel in the Home page #6568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mekarpeles , this is our first implementation of the carouzel. We would like to get some feedback from you in order to make any needed change and finish with the implementation. |
mekarpeles
reviewed
May 26, 2022
mekarpeles
reviewed
May 26, 2022
mekarpeles
reviewed
May 26, 2022
mekarpeles
reviewed
May 26, 2022
|
hi @mekarpeles we checked your reviews. Is there anything else we need to add to this PR? |
mekarpeles
added
the
Priority: 1
cdrini
force-pushed
the
6186/Carousel/Trendings-Books-Carousel
branch
from
0267ca4 to
f75e06c
Compare
cdrini
force-pushed
the
6186/Carousel/Trendings-Books-Carousel
branch
from
69b78da to
2e17b3e
Compare
jimchamp
reviewed
Jun 8, 2022
jimchamp
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6186
With this PR, a carousel containing the Today's Trending Books in the Home page.
Technical
The
get_most_logged_booksmethod used to fetch the Trending Books for the/trending/todaypage did not return the books in the correct format in order for the carousel to process and view them. So, we created theget_logged_books_carouselwhich callsget_most_logged_booksand then formats the output. This created the carousel for the first step of the implementation.Considering the second step and the carousels ability to load more books, we adjusted
browse.jsonwith adding the trending parameter. Iftrending = true, then theget_logged_books_carouselis called. To achieve pagination, themost_logged_booksmethod gets the page number as a parameter. Lastly, we added an offset variableoffset=(page-1)*limitand integrated it in the sql query.Testing
If testing in a localhost environment make sure to mark books as 'Want to Read' in order for the carousel to appear (works only for today's trending books). A
docker-compose restart memcachedis needed.Stakeholders
@mekarpeles
Attribution Disclaimer: By proposing this pull request, I affirm to have made a best-effort and exercised my discretion to make sure relevant sections of this code which substantially leverage code suggestions, code generation, or code snippets from sources (e.g. Stack Overflow, GitHub) have been annotated with basic attribution so reviewers & contributors may have confidence and access to the correct context to evaluate and use this code.