Fixed SelectionManager deselection bug #6569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…m/mheiman/openlibrary into 6556/feature/merging_enhancements
cdrini
added
the
On testing.openlibrary.org
jimchamp
removed
the
On testing.openlibrary.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #6556
When selecting items for merging, deselecting a selected item would cause the Merge Works button to disappear, even if multiple other items were still selected.
Technical
This was a simple logic error. The SelectionManager action was only being calculated on select, not on deselect. I shifted the relevant block of code out of the
if (selected)clause it was in and everything works correctly.Testing
Select and deselect some items and note that the action button and its corresponding link update appropriately.
Stakeholders
@cdrini @mheiman