Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Classics carousel show only classic books #6574

Merged
merged 3 commits into from
May 27, 2022

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented May 20, 2022

Getting complaints about some odd books showing up in here. Let's limit to something else, and monitor the Google Analytics to see if it does better or worse. Limiting to dewey decimal section 800s, books published before 1950, but which were also published sometime in the last 20 years.

Technical

Testing

Screenshot

Stakeholders

@seabelis

@cdrini cdrini force-pushed the feature/classics-carousel branch from f64d182 to 31f5fce Compare May 20, 2022 23:49
@cdrini cdrini added the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label May 25, 2022
@cdrini cdrini marked this pull request as ready for review May 25, 2022 01:45
@mekarpeles mekarpeles self-assigned this May 27, 2022
@mekarpeles mekarpeles merged commit 0f3b754 into internetarchive:master May 27, 2022
@cdrini cdrini deleted the feature/classics-carousel branch May 28, 2022 01:16
@jimchamp jimchamp removed the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants