Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script for importing pressbooks #6582

Merged
merged 4 commits into from
May 27, 2022
Merged

Add script for importing pressbooks #6582

merged 4 commits into from
May 27, 2022

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented May 25, 2022 •
edited
Loading

Technical

Testing

Screenshot

Stakeholders

@cdrini @mekarpeles
Add script for importing pressbooks
5b7e3c5 
Co-authored-by: Michael E. Karpeles (mek) <michael.karpeles@gmail.com>
cclauss
cclauss approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

scripts/import_pressbooks.py Outdated Show resolved Hide resolved
cclauss
cclauss approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

scripts/import_pressbooks.py Outdated Show resolved Hide resolved
cdrini
cdrini commented May 25, 2022
View reviewed changes
scripts/import_pressbooks.py Outdated Show resolved Hide resolved
@cdrini @cclauss
Apply suggestions from code review
2024b1f 
Co-authored-by: Christian Clauss <cclauss@me.com>
cdrini
cdrini commented May 25, 2022
View reviewed changes
scripts/import_pressbooks.py Outdated Show resolved Hide resolved
@mekarpeles mekarpeles self-assigned this May 25, 2022
cdrini
cdrini commented May 25, 2022
View reviewed changes
scripts/import_pressbooks.py Outdated Show resolved Hide resolved
cdrini and others added 2 commits May 25, 2022 17:16
@mekarpeles mekarpeles marked this pull request as ready for review May 27, 2022 23:19
@mekarpeles mekarpeles merged commit 8e6b1f7 into internetarchive:master May 27, 2022
@cdrini cdrini deleted the pressbooks-import branch May 28, 2022 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

@mekarpeles mekarpeles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdrini @cclauss @mekarpeles