Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add access solr fields to non-IA book providers #6591

Merged

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented May 27, 2022

Closes #6379

Technical

  • Moved EbookAccess and IALiteMetadata to book_providers
  • Had some import nightmares, so had to import book provider kind of funny :/ There's a circular import somewhere I can't find!

Testing

  • copydocs some openstax books and confirm they show up when has_fulltext: true

Screenshot

Stakeholders

@cdrini cdrini force-pushed the 6379/feature/tbp-hasfulltext branch 2 times, most recently from 2dfbe80 to 2817cdd Compare May 27, 2022 01:16
@cdrini cdrini mentioned this pull request May 27, 2022
63 tasks
@cdrini cdrini marked this pull request as ready for review May 27, 2022 17:43
@cdrini cdrini force-pushed the 6379/feature/tbp-hasfulltext branch from 2817cdd to 34334bd Compare May 27, 2022 20:35
@cdrini cdrini added Theme: Search Issues related to search UI and backend. [managed] Theme: Trusted Book Providers labels May 27, 2022
@mekarpeles mekarpeles marked this pull request as draft May 31, 2022 19:23
@mekarpeles mekarpeles added the State: Blocked Work has stopped, waiting for something (Info, Dependent fix, etc. See comments). [managed] label May 31, 2022
@mekarpeles mekarpeles self-assigned this May 31, 2022
@cdrini cdrini force-pushed the 6379/feature/tbp-hasfulltext branch from 34334bd to 1946df5 Compare June 15, 2022 22:19
- Moved EbookAccess and IALiteMetadata to book_providers
- Had some import nightmares, so had to import book provider kind of funny :/ There's a circular import somewhere I can't find!
@cdrini cdrini force-pushed the 6379/feature/tbp-hasfulltext branch from 1946df5 to 32e867e Compare June 15, 2022 22:51
@cdrini cdrini marked this pull request as ready for review June 15, 2022 22:52
@cdrini cdrini removed the State: Blocked Work has stopped, waiting for something (Info, Dependent fix, etc. See comments). [managed] label Jun 15, 2022
@mekarpeles
Copy link
Member

lgtm

@mekarpeles mekarpeles merged commit 823b566 into internetarchive:master Jun 15, 2022
@cdrini cdrini deleted the 6379/feature/tbp-hasfulltext branch June 15, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Theme: Search Issues related to search UI and backend. [managed] Theme: Trusted Book Providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Books with Trusted Book Providers but no OCAID should have has_fulltext: true in solr
2 participants