Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use csv_string() to streamline CSV generation #6645

Merged
merged 3 commits into from
Jun 20, 2022

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jun 9, 2022

Related to #6621 and #6653 which also use csv_string().

The csv_string() function uses iteration to generate the contents of a comma-separated values file as one long string.
For large datasets, this approach should use far less memory than storing all intermediate results as lists of lists of values.

Technical

Testing

Screenshot

Stakeholders

@cclauss cclauss changed the title Csv string Use csv_string() to streamline CSV generation Jun 9, 2022
Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cclauss, this lgtm!
We'll probably want to use csv_string() in the functions which generate reading log and list overview csvs --- this is something that I'll do later.

@jimchamp jimchamp merged commit e8bc4f7 into internetarchive:master Jun 20, 2022
@cclauss cclauss deleted the csv_string branch June 20, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants